Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4843c332 authored by Tejun Heo's avatar Tejun Heo
Browse files

percpu-refcount: improve WARN messages 



percpu_ref's WARN messages can be a lot more helpful by indicating
who's the culprit.  Make them report the release function that the
offending percpu-refcount is associated with.  This should make it a
lot easier to track down the reported invalid refcnting operations.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Kent Overstreet <kmo@daterainc.com>
parent 23cb8981

lib/percpu-refcount.c

+5 −3
Original line number Diff line number Diff line
@@ -145,8 +145,9 @@ static void percpu_ref_kill_rcu(struct rcu_head *rcu) 


	atomic_add((int) count - PCPU_COUNT_BIAS, &ref->count);



	WARN_ONCE(atomic_read(&ref->count) <= 0, "percpu ref <= 0 (%i)",

		  atomic_read(&ref->count));

	WARN_ONCE(atomic_read(&ref->count) <= 0,

		  "percpu ref (%pf) <= 0 (%i) after killed",

		  ref->release, atomic_read(&ref->count));



	/* @ref is viewed as dead on all CPUs, send out kill confirmation */

	if (ref->confirm_kill)
@@ -178,7 +179,8 @@ void percpu_ref_kill_and_confirm(struct percpu_ref *ref, 
				 percpu_ref_func_t *confirm_kill)

{

	WARN_ONCE(ref->pcpu_count_ptr & PCPU_REF_DEAD,

		  "percpu_ref_kill() called more than once!\n");

		  "percpu_ref_kill() called more than once on %pf!",

		  ref->release);



	ref->pcpu_count_ptr |= PCPU_REF_DEAD;

	ref->confirm_kill = confirm_kill;