Commit 4622676d authored Nov 04, 2019 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 27, 2020

bpf, offload: Unlock on error in bpf_offload_dev_create()



[ Upstream commit d0fbb51dfaa612f960519b798387be436e8f83c5 ]

We need to drop the bpf_devs_lock on error before returning.

Fixes: 9fd7c555 ("bpf: offload: aggregate offloads per-device")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Link: https://lore.kernel.org/bpf/20191104091536.GB31509@mwanda


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f6dfebc9

kernel/bpf/offload.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -645,8 +645,10 @@ struct bpf_offload_dev *bpf_offload_dev_create(void)
		down_write(&bpf_devs_lock);
		if (!offdevs_inited) {
		err = rhashtable_init(&offdevs, &offdevs_params);
		if (err)
		if (err) {
		up_write(&bpf_devs_lock);
		return ERR_PTR(err);
		}
		offdevs_inited = true;
		}
		up_write(&bpf_devs_lock);