Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4540a9ab authored by Neil Zhang's avatar Neil Zhang Committed by Felipe Balbi
Browse files

usb: gadget: mv_udc: fix kernel panic on some platforms 



Some platforms will use usb to download images, the controller may not
be stopped correctly when start kernel. In some cases, it may have some
pending interrupts, and they will be triggered immediately when we finish
requesting irq in function probe. But we haven't finished the device
initialization at this time. So let's stop udc here to avoid this case
occurred.

Signed-off-by: default avatarNeil Zhang <zhangwm@marvell.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 5d0b8d0f

drivers/usb/gadget/mv_udc_core.c

+7 −0
Original line number Diff line number Diff line
@@ -2037,6 +2037,13 @@ static int __devinit mv_udc_probe(struct platform_device *dev) 
			& CAPLENGTH_MASK));

	udc->max_eps = readl(&udc->cap_regs->dccparams) & DCCPARAMS_DEN_MASK;



	/*

	 * some platform will use usb to download image, it may not disconnect

	 * usb gadget before loading kernel. So first stop udc here.

	 */

	udc_stop(udc);

	writel(0xFFFFFFFF, &udc->op_regs->usbsts);



	size = udc->max_eps * sizeof(struct mv_dqh) *2;

	size = (size + DQH_ALIGNMENT - 1) & ~(DQH_ALIGNMENT - 1);

	udc->ep_dqh = dma_alloc_coherent(&dev->dev, size,