Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4495ec6d authored by Corey Minyard's avatar Corey Minyard
Browse files

ipmi:ssif: Add missing unlock in error branch 



When getting flags, a response to a different message would
result in a deadlock because of a missing unlock.  Add that
unlock and a comment.  Found by static analysis.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org # 3.19
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 1e7a75f7

drivers/char/ipmi/ipmi_ssif.c

+5 −0
Original line number Diff line number Diff line
@@ -766,6 +766,11 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result, 
			       result, len, data[2]);

		} else if (data[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2

			   || data[1] != IPMI_GET_MSG_FLAGS_CMD) {

			/*

			 * Don't abort here, maybe it was a queued

			 * response to a previous command.

			 */

			ipmi_ssif_unlock_cond(ssif_info, flags);

			pr_warn(PFX "Invalid response getting flags: %x %x\n",

				data[0], data[1]);

		} else {