Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4483320e authored by Maninder Singh's avatar Maninder Singh Committed by Vinod Koul
Browse files

dmaengine: Use Pointer xt after NULL check. 



Removing static analysis error:-
Possible null pointer dereference: xt

Because currently xt is dereferenced before NULL check,
Thus Use it after NULL Check.

Signed-off-by: default avatarManinder Singh <maninder1.s@samsung.com>
Reviewed-by: default avatarVaneet Narang <v.narang@samsung.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent fce9a74b

drivers/dma/at_hdmac.c

+3 −3
Original line number Diff line number Diff line
@@ -659,14 +659,14 @@ atc_prep_dma_interleaved(struct dma_chan *chan, 
	size_t			len = 0;

	int			i;



	if (unlikely(!xt || xt->numf != 1 || !xt->frame_size))

		return NULL;



	dev_info(chan2dev(chan),

		 "%s: src=0x%08x, dest=0x%08x, numf=%d, frame_size=%d, flags=0x%lx\n",

		__func__, xt->src_start, xt->dst_start, xt->numf,

		xt->frame_size, flags);



	if (unlikely(!xt || xt->numf != 1 || !xt->frame_size))

		return NULL;



	/*

	 * The controller can only "skip" X bytes every Y bytes, so we

	 * need to make sure we are given a template that fit that