Commit 4233cfe6 authored Oct 03, 2018 by Song Liu Committed by David S. Miller Oct 03, 2018

ixgbe: check return value of napi_complete_done()



The NIC driver should only enable interrupts when napi_complete_done()
returns true. This patch adds the check for ixgbe.

Cc: stable@vger.kernel.org # 4.10+
Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2cc543f5

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+7 −5

Original line number	Diff line number	Diff line
		@@ -3196,11 +3196,13 @@ int ixgbe_poll(struct napi_struct *napi, int budget)
		return budget;

		/* all work done, exit the polling mode */
		napi_complete_done(napi, work_done);
		if (likely(napi_complete_done(napi, work_done))) {
		if (adapter->rx_itr_setting & 1)
		ixgbe_set_itr(q_vector);
		if (!test_bit(__IXGBE_DOWN, &adapter->state))
		ixgbe_irq_enable_queues(adapter, BIT_ULL(q_vector->v_idx));
		ixgbe_irq_enable_queues(adapter,
		BIT_ULL(q_vector->v_idx));
		}

		return min(work_done, budget - 1);
		}