Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 409ef0ba authored by Marc Zyngier's avatar Marc Zyngier Committed by Eduardo Valentin
Browse files

thermal_hwmon: Sanitize attribute name passed to hwmon 



My Chromebook Plus (kevin) is spitting the following at boot time:

(NULL device *): hwmon: 'sbs-9-000b' is not a valid name attribute, please fix

Clearly, __hwmon_device_register is unhappy about the property name.
Some investigation reveals that thermal_add_hwmon_sysfs doesn't
sanitize the name of the attribute.

In order to keep it quiet, let's replace '-' with '_' in hwmon->type
This is consistent with what iio-hwmon does since b92fe9e3.

Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Tested-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent 59d7f4a7

drivers/thermal/thermal_hwmon.c

+1 −0
Original line number Diff line number Diff line
@@ -142,6 +142,7 @@ int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) 


	INIT_LIST_HEAD(&hwmon->tz_list);

	strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH);

	strreplace(hwmon->type, '-', '_');

	hwmon->device = hwmon_device_register_with_info(NULL, hwmon->type,

							hwmon, NULL, NULL);

	if (IS_ERR(hwmon->device)) {