Commit 4004a987 authored Nov 02, 2017 by Hans de Goede Committed by Greg Kroah-Hartman Nov 02, 2017

staging: rtl8188eu: Revert part of "staging: rtl8188eu: fix comments with lines over 80 characters"



Commit 74e1e498 ("staging: rtl8188eu: fix comments with lines over 80
characters") not only changed comments but also changed an if check:

-if (pmlmepriv->cur_network.join_res != true) {
+if (!(pmlmepriv->cur_network.join_res)) {

This is not equivalent as join_res is an int and can have values such
as -2 and -3.

Note for the next time, please only make one type of changes in a single
clean-up commit.

Fixes: 74e1e498 ("staging: rtl8188eu: fix comments with lines over 80 ...")
Cc: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 62ec1808

drivers/staging/rtl8188eu/core/rtw_ap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -754,7 +754,7 @@ static void start_bss_network(struct adapter padapter, u8 pbuf)
		}

		/* setting only at first time */
		if (!(pmlmepriv->cur_network.join_res)) {
		if (pmlmepriv->cur_network.join_res != true) {
		/* WEP Key will be set before this function, do not
		* clear CAM.
		*/