Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f8dd944 authored by Allan Stephens's avatar Allan Stephens Committed by Paul Gortmaker
Browse files

tipc: Prevent invalid memory access when sending to configuration service 



Reject TIPC configuration service messages without a full message
header.  Previously, an application that sent a message to the
configuration service that was too short could cause the validation
code to access an uninitialized field in the msghdr structure,
resulting in a memory access exception.

Signed-off-by: default avatarAllan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 4132faca

net/tipc/socket.c

+2 −0
Original line number Diff line number Diff line
@@ -493,6 +493,8 @@ static int dest_name_check(struct sockaddr_tipc *dest, struct msghdr *m) 
	if (likely(dest->addr.name.name.type != TIPC_CFG_SRV))

		return -EACCES;



	if (!m->msg_iovlen || (m->msg_iov[0].iov_len < sizeof(hdr)))

		return -EMSGSIZE;

	if (copy_from_user(&hdr, m->msg_iov[0].iov_base, sizeof(hdr)))

		return -EFAULT;

	if ((ntohs(hdr.tcm_type) & 0xC000) && (!capable(CAP_NET_ADMIN)))