Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f4f4c63 authored by Zhoujie Wu's avatar Zhoujie Wu Committed by Greg Kroah-Hartman
Browse files

lightnvm: pblk: consider max hw sectors supported for max_write_pgs 



[ Upstream commit 8a57fc3823d08edb1661a06d9e0a8c2365ac561e ]

When do GC, the number of read/write sectors are determined
by max_write_pgs(see gc_rq preparation in pblk_gc_line_prepare_ws).

Due to max_write_pgs doesn't consider max hw sectors
supported by nvme controller(128K), which leads to GC
tries to read 64 * 4K in one command, and see below error
caused by pblk_bio_map_addr in function pblk_submit_read_gc.

[ 2923.005376] pblk: could not add page to bio
[ 2923.005377] pblk: could not allocate GC bio (18446744073709551604)

Signed-off-by: default avatarZhoujie Wu <zjwu@marvell.com>
Reviewed-by: default avatarJavier González <javier@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <mb@lightnvm.io>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d4ab0df8

drivers/lightnvm/pblk-init.c

+2 −0
Original line number Diff line number Diff line
@@ -375,6 +375,8 @@ static int pblk_core_init(struct pblk *pblk) 
	pblk->min_write_pgs = geo->ws_opt;

	max_write_ppas = pblk->min_write_pgs * geo->all_luns;

	pblk->max_write_pgs = min_t(int, max_write_ppas, NVM_MAX_VLBA);

	pblk->max_write_pgs = min_t(int, pblk->max_write_pgs,

		queue_max_hw_sectors(dev->q) / (geo->csecs >> SECTOR_SHIFT));

	pblk_set_sec_per_write(pblk, pblk->min_write_pgs);



	if (pblk->max_write_pgs > PBLK_MAX_REQ_ADDRS) {