Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ec5693b authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5: Remove redundant EQ API exports 



EQ structure and API is private to mlx5_core driver only, external
drivers should not have access or the means to manipulate EQ objects.

Remove redundant exports and move API functions out of the linux/mlx5
include directory into the driver's mlx5_core.h private include file.

Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Reviewed-by: default avatarGal Pressman <galp@mellanox.com>
parent 3ac7afdb

drivers/net/ethernet/mellanox/mlx5/core/eq.c

+0 −3
Original line number Original line Diff line number Diff line
@@ -720,7 +720,6 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx, 
	mlx5_buf_free(dev, &eq->buf);

	mlx5_buf_free(dev, &eq->buf);

	return err;

	return err;

}

}

EXPORT_SYMBOL_GPL(mlx5_create_map_eq);





int mlx5_destroy_unmap_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq)

int mlx5_destroy_unmap_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq)

{

{
@@ -747,7 +746,6 @@ int mlx5_destroy_unmap_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq) 




	return err;

	return err;

}

}

EXPORT_SYMBOL_GPL(mlx5_destroy_unmap_eq);





int mlx5_eq_add_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq)

int mlx5_eq_add_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq)

{

{
@@ -925,4 +923,3 @@ int mlx5_core_eq_query(struct mlx5_core_dev *dev, struct mlx5_eq *eq, 
	MLX5_SET(query_eq_in, in, eq_number, eq->eqn);

	MLX5_SET(query_eq_in, in, eq_number, eq->eqn);

	return mlx5_cmd_exec(dev, in, sizeof(in), out, outlen);

	return mlx5_cmd_exec(dev, in, sizeof(in), out, outlen);

}
 
}
 
EXPORT_SYMBOL_GPL(mlx5_core_eq_query);

drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h

+17 −0
Original line number Original line Diff line number Diff line
@@ -117,11 +117,28 @@ int mlx5_destroy_scheduling_element_cmd(struct mlx5_core_dev *dev, u8 hierarchy, 
int mlx5_wait_for_vf_pages(struct mlx5_core_dev *dev);

int mlx5_wait_for_vf_pages(struct mlx5_core_dev *dev);

u64 mlx5_read_internal_timer(struct mlx5_core_dev *dev);

u64 mlx5_read_internal_timer(struct mlx5_core_dev *dev);





int mlx5_eq_init(struct mlx5_core_dev *dev);

void mlx5_eq_cleanup(struct mlx5_core_dev *dev);

int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx,

		       int nent, u64 mask, const char *name,

		       enum mlx5_eq_type type);

int mlx5_destroy_unmap_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq);

int mlx5_eq_add_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq);

int mlx5_eq_add_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq);

int mlx5_eq_del_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq);

int mlx5_eq_del_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq);

int mlx5_core_eq_query(struct mlx5_core_dev *dev, struct mlx5_eq *eq,

		       u32 *out, int outlen);

int mlx5_start_eqs(struct mlx5_core_dev *dev);

void mlx5_stop_eqs(struct mlx5_core_dev *dev);

struct mlx5_eq *mlx5_eqn2eq(struct mlx5_core_dev *dev, int eqn);

struct mlx5_eq *mlx5_eqn2eq(struct mlx5_core_dev *dev, int eqn);

u32 mlx5_eq_poll_irq_disabled(struct mlx5_eq *eq);

u32 mlx5_eq_poll_irq_disabled(struct mlx5_eq *eq);

void mlx5_cq_tasklet_cb(unsigned long data);

void mlx5_cq_tasklet_cb(unsigned long data);

void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, u64 vec, bool forced);

int mlx5_debug_eq_add(struct mlx5_core_dev *dev, struct mlx5_eq *eq);

void mlx5_debug_eq_remove(struct mlx5_core_dev *dev, struct mlx5_eq *eq);

int mlx5_eq_debugfs_init(struct mlx5_core_dev *dev);

void mlx5_eq_debugfs_cleanup(struct mlx5_core_dev *dev);

int mlx5_cq_debugfs_init(struct mlx5_core_dev *dev);

void mlx5_cq_debugfs_cleanup(struct mlx5_core_dev *dev);





int mlx5_query_pcam_reg(struct mlx5_core_dev *dev, u32 *pcam, u8 feature_group,

int mlx5_query_pcam_reg(struct mlx5_core_dev *dev, u32 *pcam, u8 feature_group,

			u8 access_reg_group);

			u8 access_reg_group);

include/linux/mlx5/driver.h

+0 −17
Original line number Original line Diff line number Diff line
@@ -1045,20 +1045,11 @@ int mlx5_satisfy_startup_pages(struct mlx5_core_dev *dev, int boot); 
int mlx5_reclaim_startup_pages(struct mlx5_core_dev *dev);

int mlx5_reclaim_startup_pages(struct mlx5_core_dev *dev);

void mlx5_register_debugfs(void);

void mlx5_register_debugfs(void);

void mlx5_unregister_debugfs(void);

void mlx5_unregister_debugfs(void);

int mlx5_eq_init(struct mlx5_core_dev *dev);

void mlx5_eq_cleanup(struct mlx5_core_dev *dev);

void mlx5_fill_page_array(struct mlx5_buf *buf, __be64 *pas);

void mlx5_fill_page_array(struct mlx5_buf *buf, __be64 *pas);

void mlx5_fill_page_frag_array(struct mlx5_frag_buf *frag_buf, __be64 *pas);

void mlx5_fill_page_frag_array(struct mlx5_frag_buf *frag_buf, __be64 *pas);

void mlx5_rsc_event(struct mlx5_core_dev *dev, u32 rsn, int event_type);

void mlx5_rsc_event(struct mlx5_core_dev *dev, u32 rsn, int event_type);

void mlx5_srq_event(struct mlx5_core_dev *dev, u32 srqn, int event_type);

void mlx5_srq_event(struct mlx5_core_dev *dev, u32 srqn, int event_type);

struct mlx5_core_srq *mlx5_core_get_srq(struct mlx5_core_dev *dev, u32 srqn);

struct mlx5_core_srq *mlx5_core_get_srq(struct mlx5_core_dev *dev, u32 srqn);

void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, u64 vec, bool forced);

int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx,

		       int nent, u64 mask, const char *name,

		       enum mlx5_eq_type type);

int mlx5_destroy_unmap_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq);

int mlx5_start_eqs(struct mlx5_core_dev *dev);

void mlx5_stop_eqs(struct mlx5_core_dev *dev);

int mlx5_vector2eqn(struct mlx5_core_dev *dev, int vector, int *eqn,

int mlx5_vector2eqn(struct mlx5_core_dev *dev, int vector, int *eqn,

		    unsigned int *irqn);

		    unsigned int *irqn);

int mlx5_core_attach_mcg(struct mlx5_core_dev *dev, union ib_gid *mgid, u32 qpn);

int mlx5_core_attach_mcg(struct mlx5_core_dev *dev, union ib_gid *mgid, u32 qpn);
@@ -1070,14 +1061,6 @@ int mlx5_core_access_reg(struct mlx5_core_dev *dev, void *data_in, 
			 int size_in, void *data_out, int size_out,

			 int size_in, void *data_out, int size_out,

			 u16 reg_num, int arg, int write);

			 u16 reg_num, int arg, int write);





int mlx5_debug_eq_add(struct mlx5_core_dev *dev, struct mlx5_eq *eq);

void mlx5_debug_eq_remove(struct mlx5_core_dev *dev, struct mlx5_eq *eq);

int mlx5_core_eq_query(struct mlx5_core_dev *dev, struct mlx5_eq *eq,

		       u32 *out, int outlen);

int mlx5_eq_debugfs_init(struct mlx5_core_dev *dev);

void mlx5_eq_debugfs_cleanup(struct mlx5_core_dev *dev);

int mlx5_cq_debugfs_init(struct mlx5_core_dev *dev);

void mlx5_cq_debugfs_cleanup(struct mlx5_core_dev *dev);

int mlx5_db_alloc(struct mlx5_core_dev *dev, struct mlx5_db *db);

int mlx5_db_alloc(struct mlx5_core_dev *dev, struct mlx5_db *db);

int mlx5_db_alloc_node(struct mlx5_core_dev *dev, struct mlx5_db *db,

int mlx5_db_alloc_node(struct mlx5_core_dev *dev, struct mlx5_db *db,

		       int node);

		       int node);