Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ead8bb2 authored by Gustavo Padovan's avatar Gustavo Padovan Committed by Daniel Vetter
Browse files

drm/i915: remove unneeded visible check 



The fb check introduced to drm_plane_helper_check_update() just make this
check impossible to branch in.

Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 083fe3b0

drivers/gpu/drm/i915/intel_display.c

+5 −16
Original line number Original line Diff line number Diff line
@@ -11639,23 +11639,12 @@ intel_check_primary_plane(struct drm_plane *plane, 
	struct drm_rect *dest = &state->dst;

	struct drm_rect *dest = &state->dst;

	struct drm_rect *src = &state->src;

	struct drm_rect *src = &state->src;

	const struct drm_rect *clip = &state->clip;

	const struct drm_rect *clip = &state->clip;

	int ret;





	ret = drm_plane_helper_check_update(plane, crtc, fb,

	return drm_plane_helper_check_update(plane, crtc, fb,

					     src, dest, clip,

					     src, dest, clip,

					     DRM_PLANE_HELPER_NO_SCALING,

					     DRM_PLANE_HELPER_NO_SCALING,

					     DRM_PLANE_HELPER_NO_SCALING,

					     DRM_PLANE_HELPER_NO_SCALING,

					     false, true, &state->visible);

					     false, true, &state->visible);

	if (ret)

		return ret;



	/* no fb bound */

	if (state->visible && !fb) {

		DRM_ERROR("No FB bound\n");

		return -EINVAL;

	}



	return 0;

}

}





static int

static int