Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3bb4e013 authored by Qian Cai's avatar Qian Cai Committed by Greg Kroah-Hartman
Browse files

slab: fix a crash by reading /proc/slab_allocators 



[ Upstream commit fcf88917dd435c6a4cb2830cb086ee58605a1d85 ]

The commit 510ded33 ("slab: implement slab_root_caches list")
changes the name of the list node within "struct kmem_cache" from "list"
to "root_caches_node", but leaks_show() still use the "list" which
causes a crash when reading /proc/slab_allocators.

You need to have CONFIG_SLAB=y and CONFIG_MEMCG=y to see the problem,
because without MEMCG all slab caches are root caches, and the "list"
node happens to be the right one.

Fixes: 510ded33 ("slab: implement slab_root_caches list")
Signed-off-by: default avatarQian Cai <cai@lca.pw>
Reviewed-by: default avatarTobin C. Harding <tobin@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a8f82720

mm/slab.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -4299,7 +4299,8 @@ static void show_symbol(struct seq_file *m, unsigned long address) 




static int leaks_show(struct seq_file *m, void *p)

static int leaks_show(struct seq_file *m, void *p)

{

{

	struct kmem_cache *cachep = list_entry(p, struct kmem_cache, list);

	struct kmem_cache *cachep = list_entry(p, struct kmem_cache,

					       root_caches_node);

	struct page *page;

	struct page *page;

	struct kmem_cache_node *n;

	struct kmem_cache_node *n;

	const char *name;

	const char *name;