Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39035bfd authored by Colin Ian King's avatar Colin Ian King Committed by Jeff Kirsher
Browse files

ixgbevf: ensure xdp_ring resources are free'd on error exit 



The current error handling for failed resource setup for xdp_ring
data is a break out of the loop and returning 0 indicated everything
was OK, when in fact it is not.  Fix this by exiting via the
error exit label err_setup_tx that will clean up the resources
correctly and return and error status.

Detected by CoverityScan, CID#1466879 ("Logically dead code")

Fixes: 21092e9c ("ixgbevf: Add support for XDP_TX action")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 9cf2f437

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3420,7 +3420,7 @@ static int ixgbevf_setup_all_tx_resources(struct ixgbevf_adapter *adapter) 
		if (!err)

			continue;

		hw_dbg(&adapter->hw, "Allocation for XDP Queue %u failed\n", j);

		break;

		goto err_setup_tx;

	}



	return 0;