Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 372d5045 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

nfp: return nfp_rtsym_read_le() errors correctly 



nfp_rtsym_read_le() has an out parameter for error codes.
We have to use that instead of returning errors directly.

Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent af623682

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c

+5 −3
Original line number Diff line number Diff line
@@ -269,8 +269,10 @@ u64 nfp_rtsym_read_le(struct nfp_cpp *cpp, const char *name, int *error) 
	int err;



	sym = nfp_rtsym_lookup(cpp, name);

	if (!sym)

		return -ENOENT;

	if (!sym) {

		err = -ENOENT;

		goto exit;

	}



	id = NFP_CPP_ISLAND_ID(sym->target, NFP_CPP_ACTION_RW, 0, sym->domain);
@@ -294,7 +296,7 @@ u64 nfp_rtsym_read_le(struct nfp_cpp *cpp, const char *name, int *error) 
		err = 0;

	else if (err >= 0)

		err = -EIO;



exit:

	if (error)

		*error = err;