Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 363da402 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

call_usermodehelper: no need to unblock signals 



____call_usermodehelper() correctly calls flush_signal_handlers() to set
SIG_DFL, but sigemptyset(->blocked) and recalc_sigpending() are not
needed.

This kthread was forked by workqueue thread, all signals must be unblocked
and ignored, no pending signal is possible.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c70a626d

kernel/kmod.c

+0 −3
Original line number Diff line number Diff line
@@ -134,11 +134,8 @@ static int ____call_usermodehelper(void *data) 
	struct subprocess_info *sub_info = data;

	int retval;



	/* Unblock all signals */

	spin_lock_irq(&current->sighand->siglock);

	flush_signal_handlers(current, 1);

	sigemptyset(&current->blocked);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);



	/* We can run anywhere, unlike our parent keventd(). */