Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35dc0b07 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: isci: remove redundant check on in_connection_align_insertion_frequency 



The sanity check on u->in_connection_align_insertion_frequency is being
performed twice and hence the first check can be removed since it is
redundant. Cleans up cppcheck warning:

drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if'
condition is always true.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9407253f

drivers/scsi/isci/init.c

+0 −3
Original line number Diff line number Diff line
@@ -433,9 +433,6 @@ static enum sci_status sci_user_parameters_set(struct isci_host *ihost, 
		      (u->max_speed_generation > SCIC_SDS_PARM_NO_SPEED)))

			return SCI_FAILURE_INVALID_PARAMETER_VALUE;



		if (u->in_connection_align_insertion_frequency < 3)

			return SCI_FAILURE_INVALID_PARAMETER_VALUE;



		if ((u->in_connection_align_insertion_frequency < 3) ||

		    (u->align_insertion_frequency == 0) ||

		    (u->notify_enable_spin_up_insertion_frequency == 0))