Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35ad6192 authored by Niklas Cassel's avatar Niklas Cassel Committed by Lorenzo Pieralisi
Browse files

PCI: endpoint: Fix find_first_zero_bit() usage 



find_first_zero_bit()'s parameter 'size' is defined in bits,
not in bytes.

Calling find_first_zero_bit() with the wrong size unit
will lead to insidious bugs.

Fix this by calling find_first_zero_bit() with size BITS_PER_LONG,
rather than sizeof() and add missing find_first_zero_bit() return
handling.

Fixes: d7467991 ("PCI: endpoint: Introduce configfs entry for configuring EP functions")
Signed-off-by: default avatarNiklas Cassel <niklas.cassel@axis.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 0c47cd7a

drivers/pci/endpoint/pci-ep-cfs.c

+4 −1
Original line number Original line Diff line number Diff line
@@ -103,7 +103,10 @@ static int pci_epc_epf_link(struct config_item *epc_item, 
	struct pci_epf *epf = epf_group->epf;

	struct pci_epf *epf = epf_group->epf;





	func_no = find_first_zero_bit(&epc_group->function_num_map,

	func_no = find_first_zero_bit(&epc_group->function_num_map,

				      sizeof(epc_group->function_num_map));

				      BITS_PER_LONG);

	if (func_no >= BITS_PER_LONG)

		return -EINVAL;



	set_bit(func_no, &epc_group->function_num_map);

	set_bit(func_no, &epc_group->function_num_map);

	epf->func_no = func_no;

	epf->func_no = func_no;