Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3497610a authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Alexandre Belloni
Browse files

rtc: stmp3xxx: print message on error 



stmp3xxx_wdt_register() can fail as platform_device_alloc() or
platform_device_add() can fail. But when it fails it failed silently.
Lets print out an error message on failure so that user will atlest
know that there was some error.

Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 6fca3fc5

drivers/rtc/rtc-stmp3xxx.c

+6 −1
Original line number Diff line number Diff line
@@ -107,14 +107,19 @@ static struct stmp3xxx_wdt_pdata wdt_pdata = { 


static void stmp3xxx_wdt_register(struct platform_device *rtc_pdev)

{

	int rc = -1;

	struct platform_device *wdt_pdev =

		platform_device_alloc("stmp3xxx_rtc_wdt", rtc_pdev->id);



	if (wdt_pdev) {

		wdt_pdev->dev.parent = &rtc_pdev->dev;

		wdt_pdev->dev.platform_data = &wdt_pdata;

		platform_device_add(wdt_pdev);

		rc = platform_device_add(wdt_pdev);

	}



	if (rc)

		dev_err(&rtc_pdev->dev,

			"failed to register stmp3xxx_rtc_wdt\n");

}

#else

static void stmp3xxx_wdt_register(struct platform_device *rtc_pdev)