Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30858973 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Michal Marek
Browse files

scripts/coccinelle: ptr_ret: Add ternary operator version 



Add a ternary operator version of the open-coded PTR_RET().

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent 8700d3cd

scripts/coccinelle/api/ptr_ret.cocci

+26 −0
Original line number Original line Diff line number Diff line
@@ -30,6 +30,13 @@ expression ptr; 
- if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;

- if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;

+ return PTR_RET(ptr);

+ return PTR_RET(ptr);





@depends on patch@

expression ptr;

@@



- (IS_ERR(ptr) ? PTR_ERR(ptr) : 0)

+ PTR_RET(ptr)



@r1 depends on !patch@

@r1 depends on !patch@

expression ptr;

expression ptr;

position p1;

position p1;
@@ -44,6 +51,13 @@ position p2; 




* if@p2 (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;

* if@p2 (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;





@r3 depends on !patch@

expression ptr;

position p3;

@@



* IS_ERR@p3(ptr) ? PTR_ERR(ptr) : 0



@script:python depends on org@

@script:python depends on org@

p << r1.p1;

p << r1.p1;

@@

@@
@@ -57,6 +71,12 @@ p << r2.p2; 




coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")

coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")





@script:python depends on org@

p << r3.p3;

@@



coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")



@script:python depends on report@

@script:python depends on report@

p << r1.p1;

p << r1.p1;

@@

@@
@@ -68,3 +88,9 @@ p << r2.p2; 
@@

@@





coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")

coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")



@script:python depends on report@

p << r3.p3;

@@



coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")