Commit 2fdaf3f4 authored May 02, 2015 by Jonathan Cameron

iio:light:ltr501 bug in parameter sanity check.



Clearly the intent was to error if the value was not 0 or 1.
As implemented we have (A != 0 || A != 1) which is always true
as A is never both 0 and 1 at the same time.

As the autobuilder suggested, && makes more sense for this error
check.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 6920ccf6

drivers/iio/light/ltr501.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -976,7 +976,7 @@ static int ltr501_write_event_config(struct iio_dev *indio_dev,
		int ret;

		/* only 1 and 0 are valid inputs */
		if (state != 1 \|\| state != 0)
		if (state != 1 && state != 0)
		return -EINVAL;

		switch (chan->type) {