Commit 2c9f1af5 authored Feb 09, 2017 by Wei Yongjun Committed by Joerg Roedel Feb 10, 2017

vfio/type1: Fix error return code in vfio_iommu_type1_attach_group()



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 5d704992 ("vfio/type1: Allow transparent MSI IOVA allocation")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent a514a6e2

drivers/vfio/vfio_iommu_type1.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -1332,8 +1332,11 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
		if (ret)
		goto out_detach;

		if (resv_msi && iommu_get_msi_cookie(domain->domain, resv_msi_base))
		if (resv_msi) {
		ret = iommu_get_msi_cookie(domain->domain, resv_msi_base);
		if (ret)
		goto out_detach;
		}

		list_add(&domain->next, &iommu->domain_list);