Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c3b2a8f authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix PRLI handling when topology type changes 



The lpfc driver does not discover a target when the topology changes
from switched-fabric to direct-connect. The target rejects the PRLI from
the initiator in direct-connect as the driver is using the old S_ID from
the switched topology.

The driver was inappropriately clearing the VP bit to register the VPI,
which is what is associated with the S_ID.

Fix by leaving the VP bit set (it was set earlier) and as the VFI is
being re-registered, set the UPDT bit.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6e8e1c14

drivers/scsi/lpfc/lpfc_mbox.c

+1 −3
Original line number Diff line number Diff line
@@ -2170,10 +2170,8 @@ lpfc_reg_vfi(struct lpfcMboxq *mbox, struct lpfc_vport *vport, dma_addr_t phys) 
	/* Only FC supports upd bit */

	if ((phba->sli4_hba.lnk_info.lnk_tp == LPFC_LNK_TYPE_FC) &&

	    (vport->fc_flag & FC_VFI_REGISTERED) &&

	    (!phba->fc_topology_changed)) {

		bf_set(lpfc_reg_vfi_vp, reg_vfi, 0);

	    (!phba->fc_topology_changed))

		bf_set(lpfc_reg_vfi_upd, reg_vfi, 1);

	}



	bf_set(lpfc_reg_vfi_bbcr, reg_vfi, 0);

	bf_set(lpfc_reg_vfi_bbscn, reg_vfi, 0);