Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b135db3 authored by Jack Morgenstein's avatar Jack Morgenstein Committed by Doug Ledford
Browse files

IB/mlx4: Forbid using sysfs to change RoCE pkeys 



The pkey mapping for RoCE must remain the default mapping:
VFs:
  virtual index 0 = mapped to real index 0 (0xFFFF)
  All others indices: mapped to a real pkey index containing an
                      invalid pkey.
PF:
  virtual index i = real index i.

Don't allow users to change these mappings using files found in
sysfs.

Fixes: c1e7e466 ('IB/mlx4: Add iov directory in sysfs under the ib device')
Signed-off-by: default avatarJack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 2cb8e7f8

drivers/infiniband/hw/mlx4/sysfs.c

+4 −1
Original line number Diff line number Diff line
@@ -640,6 +640,8 @@ static int add_port(struct mlx4_ib_dev *dev, int port_num, int slave) 
	struct mlx4_port *p;

	int i;

	int ret;

	int is_eth = rdma_port_get_link_layer(&dev->ib_dev, port_num) ==

			IB_LINK_LAYER_ETHERNET;



	p = kzalloc(sizeof *p, GFP_KERNEL);

	if (!p)
@@ -657,7 +659,8 @@ static int add_port(struct mlx4_ib_dev *dev, int port_num, int slave) 


	p->pkey_group.name  = "pkey_idx";

	p->pkey_group.attrs =

		alloc_group_attrs(show_port_pkey, store_port_pkey,

		alloc_group_attrs(show_port_pkey,

				  is_eth ? NULL : store_port_pkey,

				  dev->dev->caps.pkey_table_len[port_num]);

	if (!p->pkey_group.attrs) {

		ret = -ENOMEM;