Commit 29b33252 authored Dec 04, 2016 by Pan Bian Committed by Martin K. Petersen Dec 05, 2016

scsi: be2iscsi: set errno on error path

Variable ret is reset in the loop, and its value will be 0 during the
second and after repeat of the loop. If pci_alloc_consistent() returns a
NULL pointer then, it will leaves with return value 0. 0 means no error,
which is contrary to the fact. This patches fixes the bug, explicitly
assigning "-ENOMEM" to return variable ret on the path that the call to
pci_alloc_consistent() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188941

Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Jitendra Bhivare <Jitendra.bhivare@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 2a80d545

drivers/scsi/be2iscsi/be_main.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -3113,8 +3113,10 @@ static int beiscsi_create_cqs(struct beiscsi_hba *phba,
	cq_vaddress = pci_alloc_consistent(phba->pcidev,		cq_vaddress = pci_alloc_consistent(phba->pcidev,
	num_cq_pages * PAGE_SIZE,		num_cq_pages * PAGE_SIZE,
	&paddr);		&paddr);
	if (!cq_vaddress)		if (!cq_vaddress) {
			ret = -ENOMEM;
	goto create_cq_error;		goto create_cq_error;
			}

	ret = be_fill_queue(cq, phba->params.num_cq_entries,		ret = be_fill_queue(cq, phba->params.num_cq_entries,
	sizeof(struct sol_cqe), cq_vaddress);		sizeof(struct sol_cqe), cq_vaddress);