Commit 2980b6a8 authored Sep 05, 2018 by Arend van Spriel Committed by Greg Kroah-Hartman Nov 20, 2019

brcmfmac: increase buffer for obtaining firmware capabilities



[ Upstream commit 59c2a30d36c8ae430d26a902c4c9665ea33ccee5 ]

When obtaining the firmware capability a buffer is provided of 512
bytes. However, if all features in firmware are supported the buffer
needs to be 565 bytes as otherwise truncated information is retrieved
from firmware. Increasing the buffer to 768 bytes on stack.

Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 59d6e59f

drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -178,7 +178,7 @@ static void brcmf_feat_iovar_data_set(struct brcmf_if *ifp,
	ifp->fwil_fwerr = false;		ifp->fwil_fwerr = false;
	}		}

	#define MAX_CAPS_BUFFER_SIZE 512		#define MAX_CAPS_BUFFER_SIZE 768
	static void brcmf_feat_firmware_capabilities(struct brcmf_if *ifp)		static void brcmf_feat_firmware_capabilities(struct brcmf_if *ifp)
	{		{
	char caps[MAX_CAPS_BUFFER_SIZE];		char caps[MAX_CAPS_BUFFER_SIZE];