Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27bdc44c authored by Tony Nguyen's avatar Tony Nguyen Committed by Jeff Kirsher
Browse files

ixgbe: Allow setting zero MAC address for VF 



Currently, there is no logic that allows a VF's MAC address to be removed
from the RAR table.

Allow the user to specify a zero MAC address in order to clear the VF's
MAC address from the RAR table.  This functionality is also utilized by
libvirt when removing VFs.

Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent f87fc447

drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

+18 −10
Original line number Diff line number Diff line
@@ -1347,18 +1347,26 @@ void ixgbe_ping_all_vfs(struct ixgbe_adapter *adapter) 
int ixgbe_ndo_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)

{

	struct ixgbe_adapter *adapter = netdev_priv(netdev);

	if (!is_valid_ether_addr(mac) || (vf >= adapter->num_vfs))



	if (vf >= adapter->num_vfs)

		return -EINVAL;



	if (is_zero_ether_addr(mac)) {

		adapter->vfinfo[vf].pf_set_mac = false;

		dev_info(&adapter->pdev->dev, "removing MAC on VF %d\n", vf);

	} else if (is_valid_ether_addr(mac)) {

		adapter->vfinfo[vf].pf_set_mac = true;

	dev_info(&adapter->pdev->dev, "setting MAC %pM on VF %d\n", mac, vf);

	dev_info(&adapter->pdev->dev, "Reload the VF driver to make this"

				      " change effective.");

		dev_info(&adapter->pdev->dev, "setting MAC %pM on VF %d\n",

			 mac, vf);

		dev_info(&adapter->pdev->dev, "Reload the VF driver to make this change effective.");

		if (test_bit(__IXGBE_DOWN, &adapter->state)) {

		dev_warn(&adapter->pdev->dev, "The VF MAC address has been set,"

			 " but the PF device is not up.\n");

		dev_warn(&adapter->pdev->dev, "Bring the PF device up before"

			 " attempting to use the VF device.\n");

			dev_warn(&adapter->pdev->dev, "The VF MAC address has been set, but the PF device is not up.\n");

			dev_warn(&adapter->pdev->dev, "Bring the PF device up before attempting to use the VF device.\n");

		}

	} else {

		return -EINVAL;

	}



	return ixgbe_set_vf_mac(adapter, vf, mac);

}