Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2537e5e5 authored by Subbaraman Narayanamurthy's avatar Subbaraman Narayanamurthy
Browse files

power: qpnp-fg-gen4: Use dynamically allocated buffer for SRAM dump 



Currently, buffer for dumping SRAM periodically is allocated on
the stack. Dynamically allocate the buffer to reduce stack
footprint.

Change-Id: I35ce52d6520e85a71c6e228b172c01ba4a86619c
Signed-off-by: default avatarSubbaraman Narayanamurthy <subbaram@codeaurora.org>
parent b53c6bb3

drivers/power/supply/qcom/qpnp-fg-gen4.c

+7 −1
Original line number Diff line number Diff line
@@ -3914,14 +3914,19 @@ static void sram_dump_work(struct work_struct *work) 
{

	struct fg_dev *fg = container_of(work, struct fg_dev,

				    sram_dump_work.work);

	u8 buf[FG_SRAM_LEN];

	u8 *buf;

	int rc;

	s64 timestamp_ms, quotient;

	s32 remainder;



	buf = kcalloc(FG_SRAM_LEN, sizeof(u8), GFP_KERNEL);

	if (!buf)

		goto resched;



	rc = fg_sram_read(fg, 0, 0, buf, FG_SRAM_LEN, FG_IMA_DEFAULT);

	if (rc < 0) {

		pr_err("Error in reading FG SRAM, rc:%d\n", rc);

		kfree(buf);

		goto resched;

	}
@@ -3930,6 +3935,7 @@ static void sram_dump_work(struct work_struct *work) 
	fg_dbg(fg, FG_STATUS, "SRAM Dump Started at %lld.%d\n",

		quotient, remainder);

	dump_sram(fg, buf, 0, FG_SRAM_LEN);

	kfree(buf);

	timestamp_ms = ktime_to_ms(ktime_get_boottime());

	quotient = div_s64_rem(timestamp_ms, 1000, &remainder);

	fg_dbg(fg, FG_STATUS, "SRAM Dump done at %lld.%d\n",