Commit 2471d6f9 authored Jun 04, 2019 by Christian Brauner Committed by Joel Fernandes (Google) Aug 12, 2019

UPSTREAM: signal: improve comments



Improve the comments for pidfd_send_signal().
First, the comment still referred to a file descriptor for a process as a
"task file descriptor" which stems from way back at the beginning of the
discussion. Replace this with "pidfd" for consistency.
Second, the wording for the explanation of the arguments to the syscall
was a bit inconsistent, e.g. some used the past tense some used present
tense. Make the wording more consistent.

Signed-off-by: Christian Brauner <christian@brauner.io>

(cherry picked from commit c732327f04a3818f35fa97d07b1d64d31b691d78)

Bug: 135608568
Test: test program using syscall(__NR_sys_pidfd_open,..) and poll()
Change-Id: Iaa289e1bc2f96366102e51241accbb97099553d4
Signed-off-by: Suren Baghdasaryan <surenb@google.com>

parent 5013eebd

kernel/signal.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -3334,12 +3334,11 @@ static struct pid pidfd_to_pid(const struct file file)
		}

		/**
		* sys_pidfd_send_signal - send a signal to a process through a task file
		* descriptor
		* @pidfd: the file descriptor of the process
		* @sig: signal to be sent
		* @info: the signal info
		* @flags: future flags to be passed
		* sys_pidfd_send_signal - Signal a process through a pidfd
		* @pidfd: file descriptor of the process
		* @sig: signal to send
		* @info: signal info
		* @flags: future flags
		*
		* The syscall currently only signals via PIDTYPE_PID which covers
		* kill(<positive-pid>, <signal>. It does not signal threads or process