Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 239552f4 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (core) Make is_visible callback truly mandatory 



The is_visible callback provides the sysfs attribute mode and is thus
truly mandatory as documented. Check it once at registration and remove
other checks for its existence.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent af1bd36c

drivers/hwmon/hwmon.c

+3 −3
Original line number Diff line number Diff line
@@ -559,7 +559,7 @@ __hwmon_device_register(struct device *dev, const char *name, void *drvdata, 


	hdev = &hwdev->dev;



	if (chip && chip->ops->is_visible) {

	if (chip) {

		struct attribute **attrs;

		int ngroups = 2;
@@ -605,7 +605,7 @@ __hwmon_device_register(struct device *dev, const char *name, void *drvdata, 
	if (err)

		goto free_hwmon;



	if (chip && chip->ops->is_visible && chip->ops->read &&

	if (chip && chip->ops->read &&

	    chip->info[0]->type == hwmon_chip &&

	    (chip->info[0]->config[0] & HWMON_C_REGISTER_TZ)) {

		const struct hwmon_channel_info **info = chip->info;
@@ -673,7 +673,7 @@ hwmon_device_register_with_info(struct device *dev, const char *name, 
				const struct hwmon_chip_info *chip,

				const struct attribute_group **groups)

{

	if (chip && (!chip->ops || !chip->info))

	if (chip && (!chip->ops || !chip->ops->is_visible || !chip->info))

		return ERR_PTR(-EINVAL);



	return __hwmon_device_register(dev, name, drvdata, chip, groups);