Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 237abac6 authored by Julia Lawall's avatar Julia Lawall Committed by James Bottomley
Browse files

[SCSI] esp_scsi: Use DIV_ROUND_UP 



Use the macro DIV_ROUND_UP and eliminate the variable rounded_up, as
suggested by Matthew Wilcox.

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Cc: David Miller <davem@davemloft.net>
Reviewed-by: default avatarMatthew Wilcox <willy@linux.intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 973b7360

drivers/scsi/esp_scsi.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -1453,7 +1453,7 @@ static void esp_msgin_sdtr(struct esp *esp, struct esp_target_data *tp) 
		offset = 0;

		offset = 0;





	if (offset) {

	if (offset) {

		int rounded_up, one_clock;

		int one_clock;





		if (period > esp->max_period) {

		if (period > esp->max_period) {

			period = offset = 0;

			period = offset = 0;
@@ -1463,9 +1463,7 @@ static void esp_msgin_sdtr(struct esp *esp, struct esp_target_data *tp) 
			goto do_reject;

			goto do_reject;





		one_clock = esp->ccycle / 1000;

		one_clock = esp->ccycle / 1000;

		rounded_up = (period << 2);

		stp = DIV_ROUND_UP(period << 2, one_clock);

		rounded_up = (rounded_up + one_clock - 1) / one_clock;

		stp = rounded_up;

		if (stp && esp->rev >= FAS236) {

		if (stp && esp->rev >= FAS236) {

			if (stp >= 50)

			if (stp >= 50)

				stp--;

				stp--;