Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23475e26 authored by Roel Kluin's avatar Roel Kluin Committed by Theodore Ts'o
Browse files

ext4: Use simple_strtol() instead of simple_strtoul() in ext4_ui_proc_open



Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 171bbfbe
Loading
Loading
Loading
Loading
+3 −6
Original line number Diff line number Diff line
@@ -3521,18 +3521,15 @@ static int ext4_ui_proc_open(struct inode *inode, struct file *file)
static ssize_t ext4_ui_proc_write(struct file *file, const char __user *buf,
			       size_t cnt, loff_t *ppos)
{
	unsigned int *p = PDE(file->f_path.dentry->d_inode)->data;
	unsigned long *p = PDE(file->f_path.dentry->d_inode)->data;
	char str[32];
	unsigned long value;

	if (cnt >= sizeof(str))
		return -EINVAL;
	if (copy_from_user(str, buf, cnt))
		return -EFAULT;
	value = simple_strtol(str, NULL, 0);
	if (value < 0)
		return -ERANGE;
	*p = value;

	*p = simple_strtoul(str, NULL, 0);
	return cnt;
}