Commit 223ba92a authored Feb 23, 2018 by Antoine Tenart Committed by Greg Kroah-Hartman May 25, 2018

crypto: atmel-aes - fix the keys zeroing on errors



[ Upstream commit 5d804a51 ]

The Atmel AES driver uses memzero_explicit on the keys on error, but the
variable zeroed isn't the right one because of a typo. Fix this by using
the right variable.

Fixes: 89a82ef8 ("crypto: atmel-authenc - add support to authenc(hmac(shaX), Y(aes)) modes")
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 173c5549

drivers/crypto/atmel-aes.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2145,7 +2145,7 @@ static int atmel_aes_authenc_setkey(struct crypto_aead tfm, const u8 key,

		badkey:
		crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);
		memzero_explicit(&key, sizeof(keys));
		memzero_explicit(&keys, sizeof(keys));
		return -EINVAL;
		}