Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21ce5784 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: kobil_sct: fix NULL-deref in write 



Fix NULL-pointer dereference in write() should the device lack the
expected interrupt-out endpoint:

Unable to handle kernel NULL pointer dereference at virtual address 00000054
...
PC is at kobil_write+0x144/0x2a0 [kobil_sct]

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 5d9b0f85

drivers/usb/serial/kobil_sct.c

+12 −0
Original line number Diff line number Diff line
@@ -51,6 +51,7 @@ 




/* Function prototypes */

static int kobil_attach(struct usb_serial *serial);

static int kobil_port_probe(struct usb_serial_port *probe);

static int kobil_port_remove(struct usb_serial_port *probe);

static int  kobil_open(struct tty_struct *tty, struct usb_serial_port *port);
@@ -86,6 +87,7 @@ static struct usb_serial_driver kobil_device = { 
	.description =		"KOBIL USB smart card terminal",

	.id_table =		id_table,

	.num_ports =		1,

	.attach =		kobil_attach,

	.port_probe =		kobil_port_probe,

	.port_remove =		kobil_port_remove,

	.ioctl =		kobil_ioctl,
@@ -113,6 +115,16 @@ struct kobil_private { 
};





static int kobil_attach(struct usb_serial *serial)

{

	if (serial->num_interrupt_out < serial->num_ports) {

		dev_err(&serial->interface->dev, "missing interrupt-out endpoint\n");

		return -ENODEV;

	}



	return 0;

}



static int kobil_port_probe(struct usb_serial_port *port)

{

	struct usb_serial *serial = port->serial;