Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21ba0054 authored by Markus Elfring's avatar Markus Elfring Committed by Kalle Valo
Browse files

brcm80211: Delete an unnecessary check before the function call "release_firmware" 



The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent aeb64225

drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c

+1 −2
Original line number Diff line number Diff line
@@ -449,7 +449,6 @@ static void brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx) 


	if (raw_nvram)

		bcm47xx_nvram_release_contents(data);

	if (fw)

	release_firmware(fw);

	if (!nvram && !(fwctx->flags & BRCMF_FW_REQ_NV_OPTIONAL))

		goto fail;