Commit 1f35d04a authored Sep 21, 2015 by Dan Carpenter Committed by Greg Kroah-Hartman Oct 05, 2015

devres: fix a for loop bounds check



The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16).  This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.

Fixes: ec04b075 ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a785ce9c

lib/devres.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
		if (!iomap)
		return;

		for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
		for (i = 0; i < PCIM_IOMAP_MAX; i++) {
		if (!(mask & (1 << i)))
		continue;