Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e998547 authored by Sudheer Mogilappagari's avatar Sudheer Mogilappagari Committed by Jeff Kirsher
Browse files

i40e: Fix potential out of bound array access 



This is a fix for the static code analysis issue where dcbcfg->numapps
could be greater than size of array (i.e dcbcfg->app[I40E_DCBX_MAX_APPS]).
The fix makes sure that the array is not accessed past the size of
of the array (i.e. I40E_DCBX_MAX_APPS).

Copyright updated to 2017.

Signed-off-by: default avatarSudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 15d23b4c

drivers/net/ethernet/intel/i40e/i40e_dcb.c

+3 −1
Original line number Diff line number Diff line 
/*******************************************************************************

 *

 * Intel Ethernet Controller XL710 Family Linux Driver

 * Copyright(c) 2013 - 2014 Intel Corporation.

 * Copyright(c) 2013 - 2017 Intel Corporation.

 *

 * This program is free software; you can redistribute it and/or modify it

 * under the terms and conditions of the GNU General Public License,
@@ -390,6 +390,8 @@ static void i40e_parse_cee_app_tlv(struct i40e_cee_feat_tlv *tlv, 


	if (!dcbcfg->numapps)

		return;

	if (dcbcfg->numapps > I40E_DCBX_MAX_APPS)

		dcbcfg->numapps = I40E_DCBX_MAX_APPS;



	for (i = 0; i < dcbcfg->numapps; i++) {

		u8 up, selector;