Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e979662 authored by Hans Holmberg's avatar Hans Holmberg Committed by Greg Kroah-Hartman
Browse files

lightnvm: pblk: fix write amplificiation calculation 



[ Upstream commit 765462fa4c4d0fd3eb718f2ba14cb04c35219854 ]

When the user data counter exceeds 32 bits, the write amplification
calculation does not provide the right value. Fix this by using
div64_u64 in stead of div64.

Fixes: 76758390 ("lightnvm: pblk: export write amplification counters to sysfs")
Signed-off-by: default avatarHans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <mb@lightnvm.io>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d56fe8f5

drivers/lightnvm/pblk-sysfs.c

+1 −2
Original line number Diff line number Diff line
@@ -343,7 +343,6 @@ static ssize_t pblk_get_write_amp(u64 user, u64 gc, u64 pad, 
{

	int sz;





	sz = snprintf(page, PAGE_SIZE,

			"user:%lld gc:%lld pad:%lld WA:",

			user, gc, pad);
@@ -355,7 +354,7 @@ static ssize_t pblk_get_write_amp(u64 user, u64 gc, u64 pad, 
		u32 wa_frac;



		wa_int = (user + gc + pad) * 100000;

		wa_int = div_u64(wa_int, user);

		wa_int = div64_u64(wa_int, user);

		wa_int = div_u64_rem(wa_int, 100000, &wa_frac);



		sz += snprintf(page + sz, PAGE_SIZE - sz, "%llu.%05u\n",