Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e771039 authored by Jeremy Kerr's avatar Jeremy Kerr Committed by Arnd Bergmann
Browse files

[POWERPC] cell: catch errors from sysfs_create_group() 



We're currently getting a warning from not checking the result of
sysfs_create_group, which is declared as __must_check.

This change introduces appropriate error-handling for
spu_add_sysdev_attr_group()

Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 684bd614

arch/powerpc/platforms/cell/spu_base.c

+17 −3
Original line number Diff line number Diff line
@@ -574,13 +574,27 @@ EXPORT_SYMBOL_GPL(spu_add_sysdev_attr); 
int spu_add_sysdev_attr_group(struct attribute_group *attrs)

{

	struct spu *spu;

	int rc = 0;



	mutex_lock(&spu_full_list_mutex);

	list_for_each_entry(spu, &spu_full_list, full_list)

		sysfs_create_group(&spu->sysdev.kobj, attrs);

	list_for_each_entry(spu, &spu_full_list, full_list) {

		rc = sysfs_create_group(&spu->sysdev.kobj, attrs);



		/* we're in trouble here, but try unwinding anyway */

		if (rc) {

			printk(KERN_ERR "%s: can't create sysfs group '%s'\n",

					__func__, attrs->name);



			list_for_each_entry_continue_reverse(spu,

					&spu_full_list, full_list)

				sysfs_remove_group(&spu->sysdev.kobj, attrs);

			break;

		}

	}



	mutex_unlock(&spu_full_list_mutex);



	return 0;

	return rc;

}

EXPORT_SYMBOL_GPL(spu_add_sysdev_attr_group);