Commit 196b3167 authored Oct 01, 2009 by Roel Kluin Committed by Linus Torvalds Oct 01, 2009

cyclades: fix read buffer overflow



irq is declared with size NR_CARDS (4), but the loop containing this
segment runs up until NR_ISA_ADDRS (16), possibly reading from irq[i] (and
trying to use the result)

Identified by the Parfait static scanner.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 75e3a6ae

drivers/char/cyclades.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3354,7 +3354,7 @@ static int __init cy_detect_isa(void)
		continue;
		}
		#ifdef MODULE
		if (isparam && irq[i])
		if (isparam && i < NR_CARDS && irq[i])
		cy_isa_irq = irq[i];
		else
		#endif