Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17a51248 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Linus Walleij
Browse files

pinctrl: check ops->pin_config_set in pinconf_set_config() 



pinconf_set_config() is called by pinctrl_gpio_set_config().
If a GPIO driver is backed by a pinctrl driver and it does not
support .pin_config_set() hook, it causes NULL pointer dereference.

Fixes: 15381bc7 ("pinctrl: Allow configuration of pins from gpiolib based drivers")
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 75bb10b4

drivers/pinctrl/pinconf.c

+1 −1
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ int pinconf_set_config(struct pinctrl_dev *pctldev, unsigned pin, 
	const struct pinconf_ops *ops;



	ops = pctldev->desc->confops;

	if (!ops)

	if (!ops || !ops->pin_config_set)

		return -ENOTSUPP;



	return ops->pin_config_set(pctldev, pin, configs, nconfigs);