Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1778ca29 authored by Bruno Prémont's avatar Bruno Prémont Committed by Jiri Kosina
Browse files

HID: picolcd: correct ordering of framebuffer freeing 



Fix the free() ordering (which was never reached due to wrong check).

Signed-off-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a1060250

drivers/hid/hid-picolcd.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -550,8 +550,8 @@ static void picolcd_fb_destroy(struct fb_info *info) 
	may_release = !*ref_cnt;

	may_release = !*ref_cnt;

	mutex_unlock(&info->lock);

	mutex_unlock(&info->lock);

	if (may_release) {

	if (may_release) {

		framebuffer_release(info);

		vfree((u8 *)info->fix.smem_start);

		vfree((u8 *)info->fix.smem_start);

		framebuffer_release(info);

	}

	}

}

}