Commit 17161392 authored Jan 26, 2018 by Jia-Ju Bai Committed by Miguel Ojeda Aug 01, 2018

auxdisplay: charlcd: delete mdelay in long_sleep



The function long_sleep() calls mdelay() when in an interrupt handler.
But only charlcd_clear_display() and charlcd_init_display calls
long_sleep(), and my tool finds that the two functions
are never called in an interrupt handler.
Thus mdelay() and in_interrupt() are not necessary.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

parent acb18725

drivers/auxdisplay/charlcd.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -99,9 +99,6 @@ static atomic_t charlcd_available = ATOMIC_INIT(1);
		/* sleeps that many milliseconds with a reschedule */
		static void long_sleep(int ms)
		{
		if (in_interrupt())
		mdelay(ms);
		else
		schedule_timeout_interruptible(msecs_to_jiffies(ms));
		}