Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16cf6b80 authored by Maithili Hinge's avatar Maithili Hinge Committed by John W. Linville
Browse files

mwifiex: change memset to simple assignment for ht_cap.mcs.rx_mask 



WARNING: single byte memset is suspicious.
         Swapped 2nd/3rd argument?

This code happens to work because rx_mcs is the first variable
in mcs structure. We should use 'mcs.rx_mcs' here anyway.

Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarMaithili Hinge <maithili@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 6c9ec5eb

drivers/net/wireless/mwifiex/uap_cmd.c

+5 −3
Original line number Diff line number Diff line
@@ -175,17 +175,19 @@ mwifiex_set_ht_params(struct mwifiex_private *priv, 
		switch (GET_RXSTBC(cap_info)) {

		case MWIFIEX_RX_STBC1:

			/* HT_CAP 1X1 mode */

			memset(&bss_cfg->ht_cap.mcs, 0xff, 1);

			bss_cfg->ht_cap.mcs.rx_mask[0] = 0xff;

			break;

		case MWIFIEX_RX_STBC12:	/* fall through */

		case MWIFIEX_RX_STBC123:

			/* HT_CAP 2X2 mode */

			memset(&bss_cfg->ht_cap.mcs, 0xff, 2);

			bss_cfg->ht_cap.mcs.rx_mask[0] = 0xff;

			bss_cfg->ht_cap.mcs.rx_mask[1] = 0xff;

			break;

		default:

			dev_warn(priv->adapter->dev,

				 "Unsupported RX-STBC, default to 2x2\n");

			memset(&bss_cfg->ht_cap.mcs, 0xff, 2);

			bss_cfg->ht_cap.mcs.rx_mask[0] = 0xff;

			bss_cfg->ht_cap.mcs.rx_mask[1] = 0xff;

			break;

		}

		priv->ap_11n_enabled = 1;