Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 151ed9d7 authored by Parav Pandit's avatar Parav Pandit Committed by Jason Gunthorpe
Browse files

IB/core: Refactor to avoid unnecessary check on GID lookup miss 



Currently on every gid entry comparison miss found variable is checked;
which is not needed as those two comparison fail already indicate that
GID is not found yet.
So refactor to avoid such check and copy the GID index when found.

Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Reviewed-by: default avatarDaniel Jurgens <danielj@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent b0dd0d33

drivers/infiniband/core/cache.c

+6 −9
Original line number Diff line number Diff line
@@ -573,27 +573,24 @@ static int ib_cache_gid_find_by_filter(struct ib_device *ib_dev, 
		struct ib_gid_attr attr;



		if (table->data_vec[i].props & GID_TABLE_ENTRY_INVALID)

			goto next;

			continue;



		if (memcmp(gid, &table->data_vec[i].gid, sizeof(*gid)))

			goto next;

			continue;



		memcpy(&attr, &table->data_vec[i].attr, sizeof(attr));



		if (filter(gid, &attr, context))

		if (filter(gid, &attr, context)) {

			found = true;



next:

		if (found)

			if (index)

				*index = i;

			break;

		}

	}

	read_unlock_irqrestore(&table->rwlock, flags);



	if (!found)

		return -ENOENT;



	if (index)

		*index = i;

	return 0;

}