Commit 14ea9601 authored Jan 12, 2012 by Julia Lawall Committed by Tony Lindgren Jan 26, 2012

ARM: OMAP2+: arch/arm/mach-omap2/smartreflex.c: add missing iounmap

Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent e0feca89

arch/arm/mach-omap2/smartreflex.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -897,7 +897,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
		ret = sr_late_init(sr_info);
		if (ret) {
		pr_warning("%s: Error in SR late init\n", __func__);
		return ret;
		goto err_iounmap;
		}
		}