Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1339e2b8 authored by Trond Myklebust's avatar Trond Myklebust Committed by Greg Kroah-Hartman
Browse files

pnfs: Don't release the sequence slot until we've processed layoutget on open 



[ Upstream commit ae55e59d ]

If the server recalls the layout that was just handed out, we risk hitting
a race as described in RFC5661 Section 2.10.6.3 unless we ensure that we
release the sequence slot after processing the LAYOUTGET operation that
was sent as part of the OPEN compound.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 20fc8b34

fs/nfs/nfs4proc.c

+2 −1
Original line number Diff line number Diff line
@@ -2695,7 +2695,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, 
	if (ret != 0)

		goto out;



	state = nfs4_opendata_to_nfs4_state(opendata);

	state = _nfs4_opendata_to_nfs4_state(opendata);

	ret = PTR_ERR(state);

	if (IS_ERR(state))

		goto out;
@@ -2731,6 +2731,7 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, 
			nfs4_schedule_stateid_recovery(server, state);

	}

out:

	nfs4_sequence_free_slot(&opendata->o_res.seq_res);

	return ret;

}