Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12d60e28 authored by Wim Van Sebroeck's avatar Wim Van Sebroeck
Browse files

[WATCHDOG] iTCO_wdt: fix SMI_EN regression 2 



bugzilla: #12363
commit 7cd5b08b added a second regression:
some Dell's and Compaq's lockup on boot. So we revert most of the code.
The ICH9 reboot issue remains in place and will need some more fixing... :-(

Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent d2f8d7ee

drivers/watchdog/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -406,7 +406,7 @@ config ITCO_WDT 
	---help---

	  Hardware driver for the intel TCO timer based watchdog devices.

	  These drivers are included in the Intel 82801 I/O Controller

	  Hub family (from ICH0 up to ICH8) and in the Intel 6300ESB

	  Hub family (from ICH0 up to ICH10) and in the Intel 63xxESB

	  controller hub.



	  The TCO (Total Cost of Ownership) timer is a watchdog timer

drivers/watchdog/iTCO_vendor_support.c

+28 −4
Original line number Diff line number Diff line 
/*

 *	intel TCO vendor specific watchdog driver support

 *

 *	(c) Copyright 2006-2008 Wim Van Sebroeck <wim@iguana.be>.

 *	(c) Copyright 2006-2009 Wim Van Sebroeck <wim@iguana.be>.

 *

 *	This program is free software; you can redistribute it and/or

 *	modify it under the terms of the GNU General Public License
@@ -19,7 +19,7 @@ 


/* Module and version information */

#define DRV_NAME	"iTCO_vendor_support"

#define DRV_VERSION	"1.02"

#define DRV_VERSION	"1.03"

#define PFX		DRV_NAME ": "



/* Includes */
@@ -77,6 +77,26 @@ MODULE_PARM_DESC(vendorsupport, "iTCO vendor specific support mode, default=0 (n 
 *	    20.6 seconds.

 */



static void supermicro_old_pre_start(unsigned long acpibase)

{

	unsigned long val32;



	/* Bit 13: TCO_EN -> 0 = Disables TCO logic generating an SMI# */

	val32 = inl(SMI_EN);

	val32 &= 0xffffdfff;	/* Turn off SMI clearing watchdog */

	outl(val32, SMI_EN);	/* Needed to activate watchdog */

}



static void supermicro_old_pre_stop(unsigned long acpibase)

{

	unsigned long val32;



	/* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI# */

	val32 = inl(SMI_EN);

	val32 |= 0x00002000;	/* Turn on SMI clearing watchdog */

	outl(val32, SMI_EN);	/* Needed to deactivate watchdog */

}



static void supermicro_old_pre_keepalive(unsigned long acpibase)

{

	/* Reload TCO Timer (done in iTCO_wdt_keepalive) + */
@@ -228,14 +248,18 @@ static void supermicro_new_pre_set_heartbeat(unsigned int heartbeat) 
void iTCO_vendor_pre_start(unsigned long acpibase,

			   unsigned int heartbeat)

{

	if (vendorsupport == SUPERMICRO_NEW_BOARD)

	if (vendorsupport == SUPERMICRO_OLD_BOARD)

		supermicro_old_pre_start(acpibase);

	else if (vendorsupport == SUPERMICRO_NEW_BOARD)

		supermicro_new_pre_start(heartbeat);

}

EXPORT_SYMBOL(iTCO_vendor_pre_start);



void iTCO_vendor_pre_stop(unsigned long acpibase)

{

	if (vendorsupport == SUPERMICRO_NEW_BOARD)

	if (vendorsupport == SUPERMICRO_OLD_BOARD)

		supermicro_old_pre_stop(acpibase);

	else if (vendorsupport == SUPERMICRO_NEW_BOARD)

		supermicro_new_pre_stop();

}

EXPORT_SYMBOL(iTCO_vendor_pre_stop);

drivers/watchdog/iTCO_wdt.c

+14 −21
Original line number Diff line number Diff line 
/*

 *	intel TCO Watchdog Driver (Used in i82801 and i6300ESB chipsets)

 *	intel TCO Watchdog Driver (Used in i82801 and i63xxESB chipsets)

 *

 *	(c) Copyright 2006-2008 Wim Van Sebroeck <wim@iguana.be>.

 *	(c) Copyright 2006-2009 Wim Van Sebroeck <wim@iguana.be>.

 *

 *	This program is free software; you can redistribute it and/or

 *	modify it under the terms of the GNU General Public License
@@ -63,7 +63,7 @@ 


/* Module and version information */

#define DRV_NAME	"iTCO_wdt"

#define DRV_VERSION	"1.04"

#define DRV_VERSION	"1.05"

#define PFX		DRV_NAME ": "



/* Includes */
@@ -338,7 +338,6 @@ static int iTCO_wdt_unset_NO_REBOOT_bit(void) 
static int iTCO_wdt_start(void)

{

	unsigned int val;

	unsigned long val32;



	spin_lock(&iTCO_wdt_private.io_lock);
@@ -351,11 +350,6 @@ static int iTCO_wdt_start(void) 
		return -EIO;

	}



	/* Bit 13: TCO_EN -> 0 = Disables TCO logic generating an SMI# */

	val32 = inl(SMI_EN);

	val32 &= 0xffffdfff;	/* Turn off SMI clearing watchdog */

	outl(val32, SMI_EN);



	/* Force the timer to its reload value by writing to the TCO_RLD

	   register */

	if (iTCO_wdt_private.iTCO_version == 2)
@@ -378,7 +372,6 @@ static int iTCO_wdt_start(void) 
static int iTCO_wdt_stop(void)

{

	unsigned int val;

	unsigned long val32;



	spin_lock(&iTCO_wdt_private.io_lock);
@@ -390,11 +383,6 @@ static int iTCO_wdt_stop(void) 
	outw(val, TCO1_CNT);

	val = inw(TCO1_CNT);



	/* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI# */

	val32 = inl(SMI_EN);

	val32 |= 0x00002000;

	outl(val32, SMI_EN);



	/* Set the NO_REBOOT bit to prevent later reboots, just for sure */

	iTCO_wdt_set_NO_REBOOT_bit();
@@ -649,6 +637,7 @@ static int __devinit iTCO_wdt_init(struct pci_dev *pdev, 
	int ret;

	u32 base_address;

	unsigned long RCBA;

	unsigned long val32;



	/*

	 *      Find the ACPI/PM base I/O address which is the base
@@ -695,6 +684,10 @@ static int __devinit iTCO_wdt_init(struct pci_dev *pdev, 
		ret = -EIO;

		goto out;

	}

	/* Bit 13: TCO_EN -> 0 = Disables TCO logic generating an SMI# */

	val32 = inl(SMI_EN);

	val32 &= 0xffffdfff;	/* Turn off SMI clearing watchdog */

	outl(val32, SMI_EN);



	/* The TCO I/O registers reside in a 32-byte range pointed to

	   by the TCOBASE value */