Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10ad5278 authored by Rahul Ruikar's avatar Rahul Ruikar Committed by Linus Torvalds
Browse files

drivers/misc/phantom.c: add missing warning messages in phantom_probe() 



phantom_probe() can fail in many places.  Add missing warning messages in
pci_enable_device() and pci_request_regions().

Signed-off-by: default avatarRahul Ruikar <rahul.ruikar@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ca1cab37

drivers/misc/phantom.c

+6 −2
Original line number Diff line number Diff line
@@ -343,8 +343,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev, 
	int retval;



	retval = pci_enable_device(pdev);

	if (retval)

	if (retval) {

		dev_err(&pdev->dev, "pci_enable_device failed!\n");

		goto err;

	}



	minor = phantom_get_free();

	if (minor == PHANTOM_MAX_MINORS) {
@@ -356,8 +358,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev, 
	phantom_devices[minor] = 1;



	retval = pci_request_regions(pdev, "phantom");

	if (retval)

	if (retval) {

		dev_err(&pdev->dev, "pci_request_regions failed!\n");

		goto err_null;

	}



	retval = -ENOMEM;

	pht = kzalloc(sizeof(*pht), GFP_KERNEL);