Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0dbfaa9f authored by Ira Weiny's avatar Ira Weiny Committed by Jason Gunthorpe
Browse files

IB/hfi1: Fix SL array bounds check 



The SL specified by a user needs to be a valid SL.

Add a range check to the user specified SL value which protects from
running off the end of the SL to SC table.

CC: stable@vger.kernel.org
Fixes: 77241056 ("IB/hfi1: add driver files")
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 4eeed368

drivers/infiniband/hw/hfi1/verbs.c

+7 −1
Original line number Diff line number Diff line
@@ -1582,6 +1582,7 @@ static int hfi1_check_ah(struct ib_device *ibdev, struct rdma_ah_attr *ah_attr) 
	struct hfi1_pportdata *ppd;

	struct hfi1_devdata *dd;

	u8 sc5;

	u8 sl;



	if (hfi1_check_mcast(rdma_ah_get_dlid(ah_attr)) &&

	    !(rdma_ah_get_ah_flags(ah_attr) & IB_AH_GRH))
@@ -1590,8 +1591,13 @@ static int hfi1_check_ah(struct ib_device *ibdev, struct rdma_ah_attr *ah_attr) 
	/* test the mapping for validity */

	ibp = to_iport(ibdev, rdma_ah_get_port_num(ah_attr));

	ppd = ppd_from_ibp(ibp);

	sc5 = ibp->sl_to_sc[rdma_ah_get_sl(ah_attr)];

	dd = dd_from_ppd(ppd);



	sl = rdma_ah_get_sl(ah_attr);

	if (sl >= ARRAY_SIZE(ibp->sl_to_sc))

		return -EINVAL;



	sc5 = ibp->sl_to_sc[sl];

	if (sc_to_vlt(dd, sc5) > num_vls && sc_to_vlt(dd, sc5) != 0xf)

		return -EINVAL;

	return 0;